![]() ![]() But when presented with a UI, even though the UI is just a facade over modifying the file, "saving and closing" isn't the obvious thing to do. When I'm working in text file mode, my mental model is "this is a file, and it will be processed when I close it", so saving/closing is natural. I also agree with the idea that the buttons (both Continue and Abort) should have keyboard shortcuts, despite the fact (as you noted) that you can just save and close the tab to "save". It prevents you from accidentally making invalid or useless edits (like misspelling command names, or uselessly modifying commit messages), and the abort button is useful too. There are definitely some things I like about the new interface. f or alt↓), the new editor would be an improvement for me instead of a hinderance. hold shift to select multiple commits, then press act on all of them (e.g. Frequently, the reason that I'm rebasing is that I want to squash a large number of consecutive commits (generally small fixups). That being said, unless I'm missing something, my assumption was correct for the one bit of keyboard support I actually care about.Īs far as I can see, there's no way to set actions for multiple commits at once, and that's what I'd want before re-enabling the interactive editor. I think the confusion, is that in the rebase UI, I show you a "static" view of the commit that your rebase will sit on top of for added I will admit, I was so completely thrown off by the sudden change, that I assumed there was no keyboard support and immediately looked for a way to disable it. There should be no difference in the commits that can be affected as part of the rebase. I couldn't drop the first commit, and I wanted to the first time I tried a rebase and this editor popped up (I often do something like git rebase -i master to just get my branch commits, and would like to be able modify all of them however I want) Although since this experience is just a facade on top of the normal git-rebase-todo document, can still use the normal vscode save shortcut to save the changes you made, and the close the tab (again with the normal vscode shortcut) I don't have any specific keyboard shortcut for the Start Rebase button, but maybe I should add something like Ctrl+Enter. The new UI, should be fully keyboard accessible - just using the arrow keys to move around and the others listed: Weirdly the spacing threw me off too, probably just cause I'm used to reading the text list, but them being farther apart than I expected was uncomfortable and felt hard to readĬlicking buttons is a lot slower than just using the keyboard to move lines around to where I want them and multi-edit a bunch of commits to fix up at once Would an option to switch the order make it better? The ordering is backwards from what I'm used toĪgree, it took me a bit to get used to it this way, but imo this order is more natural/expected (if you weren't corrupted by the existing behavior). Thank you so much for the awesome tool! I'm glad I can turn this off rather than disabling the plugin, which I really Thanks for the feedback. I couldn't drop the first commit, and I wanted to the first time I tried a rebase and this editor popped up (I often do something like git rebase -i master to just get my branch commits, and would like to be able modify all of them however I want).clicking buttons is a lot slower than just using the keyboard to move lines around to where I want them and multi-edit a bunch of commits to fix up at once.weirdly the spacing threw me off too, probably just cause I'm used to reading the text list, but them being farther apart than I expected was uncomfortable and felt hard to read. ![]() the ordering is backwards from what I'm used to.Honestly, I might like it a lot if I was new to interactive rebasing, but as someone who already uses it a lot these things threw me off: ![]() I turned it off because I frequently use interactive rebase and am used to my current workflow.
0 Comments
Leave a Reply. |
AuthorWrite something about yourself. No need to be fancy, just an overview. ArchivesCategories |